Skip to content

python310Packages.httpie: re-enable tests#210996

Closed
alexshpilkin wants to merge 2 commits intoNixOS:masterfrom
alexshpilkin:enable-httpie-tests
Closed

python310Packages.httpie: re-enable tests#210996
alexshpilkin wants to merge 2 commits intoNixOS:masterfrom
alexshpilkin:enable-httpie-tests

Conversation

@alexshpilkin
Copy link
Member

@alexshpilkin alexshpilkin commented Jan 15, 2023

Description of changes

An upstream fix for the test failures discovered in #205270 has landed as httpie/cli@e73c3e6, so pick up that patch until the next version is released and revert #207035 which disabled the tests.

h/t @dbaynard @mweinelt

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 15, 2023
@mweinelt mweinelt requested a review from fabaff January 15, 2023 22:58
@ofborg ofborg bot requested review from relrod and schneefux January 15, 2023 23:05
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 15, 2023
@fabaff
Copy link
Member

fabaff commented Jan 16, 2023 •
edited
Loading

Result of nixpkgs-review pr 210996 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.httpie
  • python311Packages.httpie-ntlm
3 packages built:
  • http-prompt
  • httpie (python310Packages.httpie)
  • python310Packages.httpie-ntlm

Perhaps only related to Python 3.11:

[...]
       last 10 log lines:
       > FAILED tests/test_cli.py::test_url_colon_slash_slash_only - AssertionError: assert 'http: LogLev...host supplied' == 'http: error:...ho...
       > FAILED tests/test_output.py::TestQuietFlag::test_quiet_with_check_status_non_zero - AssertionError: assert 'http: warning: HTTP 500' in '\nhttp: LogLevel.WARNI...
       > FAILED tests/test_output.py::TestQuietFlag::test_quiet_with_check_status_non_zero_pipe - AssertionError: assert 'http: warning: HTTP 500' in '\nhttp: LogLevel.WARNI...
       > FAILED tests/test_output.py::TestQuietFlag::test_quiet_quiet_with_check_status_non_zero_pipe - AssertionError: assert 'http: warning: HTTP 500' in '\nhttp: LogLevel.WARNI...
       > FAILED tests/test_plugins_cli.py::test_plugins_upgrade - AssertionError: assert '1.0.0' == '2.0.0'
       > FAILED tests/test_sessions.py::TestCookieStorage::test_existing_and_new_cookies_sent_in_request[new=bar;chocolate=milk-new_cookies_dict1-chocolate=milk; cookie1=foo; cookie2=foo; new=bar] - AssertionError: assert 'Cookie: chocolate=milk; cookie1=foo; cookie2=foo; n...
       > FAILED tests/test_sessions.py::TestCookieStorage::test_existing_and_new_cookies_sent_in_request[new=bar; chocolate=milk-new_cookies_dict2-chocolate=milk; cookie1=foo; cookie2=foo; new=bar] - AssertionError: assert 'Cookie: chocolate=milk; cookie1=foo; cookie2=foo; n...
       > FAILED tests/test_sessions.py::TestCookieStorage::test_existing_and_new_cookies_sent_in_request[new=bar; chocolate=milk;;;-new_cookies_dict4-chocolate=milk; cookie1=foo; cookie2=foo; new=bar] - AssertionError: assert 'Cookie: chocolate=milk; cookie1=foo; cookie2=foo; n...
       > = 8 failed, 986 passed, 25 skipped, 3 deselected, 2 xfailed, 2 xpassed, 345 warnings in 81.55s (0:01:21) =
       > /nix/store/chilfhdcsnmwjl7igrw26j1lrc0zar35-stdenv-linux/setup: line 1570: pop_var_context: head of shell_variables not a function context

@alexshpilkin
Copy link
Member Author

alexshpilkin commented Jan 16, 2023 •
edited
Loading

@fabaff Huh. Thanks! I did nixpkgs-review rev locally but that didn’t catch it—perhaps because at the point I based this on (a4379d2) a dependency of httpie (EDIT: ephemeral-port-reserve) did not build either? I’ll look into it.

@alexshpilkin
Copy link
Member Author

alexshpilkin commented Jan 16, 2023

Right, so python311Packages.ephemeral-port-reserve doesn’t even build (or more precisely fails tests) on current nixpkgs-unstable, it only works only on master. And yes, this looks like independent 3.11-induced breakage. The first four failures (in test_cli.py and test_output.py) I think are due to the changes to enum.Enum.__format__; the one in test_plugins_cli.py is a genuine failure I’m not sure about; the final three in test_sessions.py are because the cookies in the mock response aren’t ordered the way the test expects (?).

Should I just disable these on ≥ 3.11 and let upstream sort it out? FWIW, the prerequisites on 3.12 seem quite broken for now.

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank marked this pull request as draft March 21, 2024 12:12
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@NickCao
Copy link
Member

NickCao commented Dec 4, 2024

No longer relevant.

@NickCao NickCao closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

@schneefux schneefux Awaiting requested review from schneefux

@relrod relrod Awaiting requested review from relrod

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexshpilkin @fabaff @NickCao @wegank